Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The subscription to the Source.CollectionChanged event of FilteredReadOnlyObservableCollection is not being unsubscribed at the time of Dispose. #450

Closed
ryo1988 opened this issue Oct 19, 2023 · 4 comments
Assignees
Labels

Comments

@ryo1988
Copy link
Contributor

ryo1988 commented Oct 19, 2023

English

https://github.com/runceel/ReactiveProperty/blob/a5590692978043ab3ab8e844e2294b25d4a08f50/Source/ReactiveProperty.NETStandard/Helpers/FilteredReadOnlyObservableCollection.cs#L351C55-L351C55

It is written as CollectionChanged -= Source_CollectionChanged;

However, it seems to need to be Source.CollectionChanged -= Source_CollectionChanged;

Japanese

https://github.com/runceel/ReactiveProperty/blob/a5590692978043ab3ab8e844e2294b25d4a08f50/Source/ReactiveProperty.NETStandard/Helpers/FilteredReadOnlyObservableCollection.cs#L351C55-L351C55

CollectionChanged -= Source_CollectionChanged;

となっていますが、

Source.CollectionChanged -= Source_CollectionChanged;

である必要がありそうです。

@runceel
Copy link
Owner

runceel commented Oct 29, 2023

@ryo1988 ありがとうございます。マージしました。近いうちにリリースします。

@runceel runceel closed this as completed Oct 29, 2023
@runceel
Copy link
Owner

runceel commented Oct 29, 2023

プレビューパッケージとして公開しました。
特に問題なければ、このままリリース版として公開予定です。

https://www.nuget.org/packages/ReactiveProperty.WPF/9.3.4-pre202310290551

@ryo1988
Copy link
Contributor Author

ryo1988 commented Oct 30, 2023

リリースありがとうございます。

@runceel
Copy link
Owner

runceel commented Oct 31, 2023

@ryo1988
すいません。元記事に英文書き足しました。

@runceel runceel changed the title FilteredReadOnlyObservableCollectionのSource.CollectionChangedへのイベント購読が、Dispose時に購読解除できていないようです。 The subscription to the Source.CollectionChanged event of FilteredReadOnlyObservableCollection is not being unsubscribed at the time of Dispose. Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants