Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Annotations to secrets #140

Closed
ekhaydarov opened this issue Apr 12, 2022 · 1 comment · Fixed by #356
Closed

Add Annotations to secrets #140

ekhaydarov opened this issue Apr 12, 2022 · 1 comment · Fixed by #356
Assignees
@GMartinez-Sisti

Comments

@ekhaydarov
Copy link

Currently there are annotations available to statefulSet and podAnnotations. Looking through secret-webhook.yaml we can see that only labels are added. Would it be possible to allow to annotate secrets, or in fact all the k8s objects?
@GMartinez-Sisti
Copy link
Member

We could ensure all the objects have annotations, along with a global annotation that would be included on all resources when defined.

Should I implement this?

@GMartinez-Sisti GMartinez-Sisti self-assigned this Feb 27, 2024
@GMartinez-Sisti GMartinez-Sisti mentioned this issue Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GMartinez-Sisti GMartinez-Sisti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(annotations): add global annotations GMartinez-Sisti/runatlantis-helm-charts
2 participants
@ekhaydarov @GMartinez-Sisti