From 848e08346c48182605ccaaa37e51af4b784703d4 Mon Sep 17 00:00:00 2001
From: aleksy-zalenski <46108036+aleksy-zalenski@users.noreply.github.com>
Date: Fri, 2 Aug 2024 18:50:26 +0200
Subject: [PATCH] Allow setting externalTrafficPolicy on service (#411)

* Allow setting externalTrafficPolicy on service

* Bump the chart version to 5.4.4
---
 charts/atlantis/Chart.yaml              | 2 +-
 charts/atlantis/README.md               | 1 +
 charts/atlantis/templates/service.yaml  | 3 +++
 charts/atlantis/tests/service_test.yaml | 8 ++++++++
 charts/atlantis/values.schema.json      | 7 +++++++
 charts/atlantis/values.yaml             | 1 +
 6 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/charts/atlantis/Chart.yaml b/charts/atlantis/Chart.yaml
index 7e90ff19..48a723a4 100644
--- a/charts/atlantis/Chart.yaml
+++ b/charts/atlantis/Chart.yaml
@@ -3,7 +3,7 @@ apiVersion: v1
 appVersion: v0.28.5
 description: A Helm chart for Atlantis https://www.runatlantis.io
 name: atlantis
-version: 5.4.3
+version: 5.4.4
 keywords:
   - terraform
 home: https://www.runatlantis.io
diff --git a/charts/atlantis/README.md b/charts/atlantis/README.md
index f51b319f..2c6fc5ce 100644
--- a/charts/atlantis/README.md
+++ b/charts/atlantis/README.md
@@ -179,6 +179,7 @@ extraManifests:
 | repoConfig | string | `""` | Use Server Side Repo Config, ref: https://www.runatlantis.io/docs/server-side-repo-config.html. Check values.yaml for examples. |
 | resources | object | `{}` | Resources for Atlantis. Check values.yaml for examples. |
 | service.annotations | object | `{}` |  |
+| service.externalTrafficPolicy | string | `nil` |  |
 | service.loadBalancerIP | string | `nil` |  |
 | service.loadBalancerSourceRanges | list | `[]` |  |
 | service.nodePort | string | `nil` |  |
diff --git a/charts/atlantis/templates/service.yaml b/charts/atlantis/templates/service.yaml
index 152c2225..d26ebdc5 100644
--- a/charts/atlantis/templates/service.yaml
+++ b/charts/atlantis/templates/service.yaml
@@ -21,6 +21,9 @@ spec:
   {{- if .Values.service.loadBalancerIP }}
   loadBalancerIP: {{ .Values.service.loadBalancerIP }}
   {{- end }}
+  {{- if .Values.service.externalTrafficPolicy }}
+  externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
+  {{- end }}
   type: {{ .Values.service.type }}
   ports:
     - port: {{ .Values.service.port }}
diff --git a/charts/atlantis/tests/service_test.yaml b/charts/atlantis/tests/service_test.yaml
index 892f61e0..8e174472 100644
--- a/charts/atlantis/tests/service_test.yaml
+++ b/charts/atlantis/tests/service_test.yaml
@@ -27,6 +27,14 @@ tests:
               app: atlantis
               release: my-release
             type: NodePort
+  - it: externalTrafficPolicy
+    set:
+      service:
+        externalTrafficPolicy: Local
+    asserts:
+      - equal:
+          path: spec.externalTrafficPolicy
+          value: Local
   - it: loadBalancerSourceRanges
     set:
       service:
diff --git a/charts/atlantis/values.schema.json b/charts/atlantis/values.schema.json
index fc522503..2353aa76 100644
--- a/charts/atlantis/values.schema.json
+++ b/charts/atlantis/values.schema.json
@@ -514,6 +514,13 @@
           ],
           "default": 4141
         },
+        "externalTrafficPolicy": {
+          "description": "externalTrafficPolicy to set on service.",
+          "type": [
+            "string",
+            "null"
+          ]
+        },
         "loadBalancerIP": {
           "description": "IP address to assign to load balancer (if supported).",
           "type": [
diff --git a/charts/atlantis/values.yaml b/charts/atlantis/values.yaml
index e223d116..a799ace4 100644
--- a/charts/atlantis/values.yaml
+++ b/charts/atlantis/values.yaml
@@ -290,6 +290,7 @@ service:
   targetPort: 4141
   loadBalancerIP: null
   loadBalancerSourceRanges: []
+  externalTrafficPolicy: null
 
 podTemplate:
   # -- Check values.yaml for examples.