Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket Cloud 'nickname' field is missing, still uses 'username' #896

Closed
hatemosphere opened this issue Jan 11, 2020 · 3 comments
Closed
Labels
provider/bitbucket waiting-on-response Waiting for a response from the user

Comments

@hatemosphere
Copy link

hatemosphere commented Jan 11, 2020

I see this PR #502 references API deprecation doc, but apparently actor object still (as of today) contains username field and i get was missing fields: Key: 'PullRequestEvent.CommonEventData.Actor.Nickname' Error:Field validation for 'Nickname' failed on the 'required' Error when receiving payload. @lkysow I guess this PR needs to be reverted?

@hatemosphere
Copy link
Author

hatemosphere commented Jan 11, 2020

    "actor": {
        "username": "xxx",
        "display_name": "xxx",
        "type": "team",
        "uuid": "{xxx}",
        "links": {
            "self": {
                "href": "https://api.bitbucket.org/2.0/teams/%!B(MISSING)xxx%!D(MISSING)"
            },
            "html": {
                "href": "https://bitbucket.org/%!B(MISSING)xxx%!D(MISSING)/"
            },
            "avatar": {
                "href": "https://bitbucket.org/account/xxx/avatar/"
            }
        }
    }

here you can see actor object in payload coming from Bitbucket Cloud

@lkysow
Copy link
Member

lkysow commented Jan 20, 2020

Are you still seeing this? Maybe it was a bug on their end? I see this field in my testing today:

  "actor": {
    "display_name": "Atlantisbot",
    "account_id": "5b5097035488b91478f7f",
    "links": {
      "self": {
        "href": "https://api.bitbucket.org/2.0/users/%7B73686412-4495-426f-c69ff1c8d7b8%7D"
      },
      "html": {
        "href": "https://bitbucket.org/%7B73686412-4495-426f-c69ff1c8d7b8%7D/"
      },
      "avatar": {
        "href": "https://avatar-management--avatars.us-west-2.prod.public.atl-paas.net/5b5097035488b9140c078f7f/40eee718-5570-8149-0b95de7921f8/128"
      }
    },
    "nickname": "atlantis-bot",
    "type": "user",
    "uuid": "{73686412-4495-426f-c69ff1c8d7b8}"
  }

Can you give me a way to reproduce?

@lkysow lkysow added the waiting-on-response Waiting for a response from the user label Jan 20, 2020
@hatemosphere
Copy link
Author

i can confirm this issue does not exist anymore! looks like Bitbucket was trolling us...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/bitbucket waiting-on-response Waiting for a response from the user
Projects
None yet
Development

No branches or pull requests

3 participants