Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support top level modules folder with directory-based config #6

Closed
lkysow opened this issue Feb 14, 2018 · 1 comment
Closed

Support top level modules folder with directory-based config #6

lkysow opened this issue Feb 14, 2018 · 1 comment

Comments

@lkysow
Copy link
Member

lkysow commented Feb 14, 2018

Given the following directory structure:

modules/
  module1/
    main.tf
vpc/
  main.tf

If a change is made to both module1/main.tf and vpc/main.tf, Atlantis will attempt to run terraform plan in vpc/ (which is correct) and in the root of the project (which is incorrect).

This occurs due to an attempt to support this type of structure:

main.tf
modules/
  module1/
    main.tf

The way Atlantis works right now is we assume if there's a change in any directory called modules we should run plan/apply in the root.

Possible solutions:

  • requiring an atlantis.yaml file in all project roots. We don't run anywhere that doesn't have one
  • detecting if there are no .tf files in the parent of modules/ and not running there if that's the case
@lkysow
Copy link
Member Author

lkysow commented Feb 28, 2018

Fixed by #13. Will no longer run plan in the parent dir of modules/ unless there is a main.tf in that dir.

@lkysow lkysow closed this as completed Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant