Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new PR with auto-plan disabled shows a green status check #549

Closed
marcb1 opened this issue Mar 25, 2019 · 4 comments
Closed

Creating a new PR with auto-plan disabled shows a green status check #549

marcb1 opened this issue Mar 25, 2019 · 4 comments
Labels
bug Something isn't working waiting-on-response Waiting for a response from the user

Comments

@marcb1
Copy link
Contributor

marcb1 commented Mar 25, 2019

Running atlantis version 0.5.1, with auto-plan disabled. I noticed when I create a new PR there's automatically a green status check for plan/atlantis:
image

@lkysow lkysow added the bug Something isn't working label Apr 4, 2019
@lkysow
Copy link
Member

lkysow commented Apr 17, 2019

So I'm not really sure what to do here. We've already set a "Pending" check status, and the GitHub API doesn't let us delete the status. So we could leave it as pending. However, if the pull request doesn't require any planning, then it's going to be pending forever.

@marcb1
Copy link
Contributor Author

marcb1 commented Apr 17, 2019

I like having the pending check. Usually in a terraform repo, I wouldn't expect many PR's to be opened that don't require planning. If this ever happens, maybe users can run an empty plan and merge, or an administrator can merge it.

@jamengual
Copy link
Contributor

is this still an issue with v0.19.8?

@jamengual jamengual added the waiting-on-response Waiting for a response from the user label Aug 26, 2022
@github-actions
Copy link

This issue is stale because it has been open for 6 months with no activity. Remove stale label or comment or this will be closed in 1 month.'

@github-actions github-actions bot added the Stale label Feb 26, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting-on-response Waiting for a response from the user
Projects
None yet
Development

No branches or pull requests

3 participants