Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Ignoring unsupported event when a custom property is set #5044

Closed
chriscapell opened this issue Oct 25, 2024 · 4 comments
Closed

Error: Ignoring unsupported event when a custom property is set #5044

chriscapell opened this issue Oct 25, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@chriscapell
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

While setting up Atlantis, the webhook would fire, but return "Ignoring unsupported event" for supported events. After building the image locally with extra debug steps, I was able to determine the line and get a better error message Error parsing webhook: json: cannot unmarshal array into Go struct field Repository.repository.custom_properties of type string . When I removed the value from custom properties I had set on my repo, the issue went away

@chriscapell chriscapell added the bug Something isn't working label Oct 25, 2024
Copy link

dosubot bot commented Oct 25, 2024

I found a similar discussion regarding the issue of "Ignoring unsupported event" when custom properties are set. In this discussion, a user experienced a similar problem where custom properties on their GitHub repository caused the webhook parsing to fail. The solution was to remove the custom properties, which resolved the issue [1].

It seems that the custom properties in the webhook payload might not be handled correctly by Atlantis, leading to parsing errors. If you have custom properties set, consider removing them to see if it resolves the issue.

To continue talking to Dosu, mention @dosu.

@stasostrovskyi
Copy link
Contributor

This seems to be the same issue as here - #4989 (comment) and seems to stem from go-github (https://github.com/google/go-github), specifically - https://github.com/google/go-github/blob/master/github/messages.go#L319

@philwitty
Copy link

I checked and this was fixed in https://github.com/google/go-github/releases/tag/v64.0.0 however atlantis wasn't bumped to this version until 2 weeks ago after the latest release

@chriscapell
Copy link
Author

Thanks. I'm going to close this as it appears that the fix is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants