Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden Policy Results with Custom Policies #4961

Open
Mezage opened this issue Sep 27, 2024 · 1 comment
Open

Hidden Policy Results with Custom Policies #4961

Mezage opened this issue Sep 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Mezage
Copy link

Mezage commented Sep 27, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

So I've noticed that when upgrading to v0.28.0, our policy blocks would be hidden sometime in a collapsable comment. So if I had 2 plans, only the first one policy check for that plan would appear and the 2nd one would be hidden.

Reproduction Steps

Enable custom policy check, upgrade to v0.28.0 and just run atlantis plan
Screenshot 2024-09-27 at 12 08 44 PM

Only see 2nd policy block when clicking on "show output" of first policy block, and it expands the entire output for the run.

Environment details

  • Atlantis version: v0.28.0

Repo atlantis.yaml file:

Screenshot 2024-09-27 at 12 06 28 PM
@Mezage Mezage added the bug Something isn't working label Sep 27, 2024
Copy link

dosubot bot commented Sep 27, 2024

Hey @Mezage! I'm here to help you with any issues, answer your questions, and guide you on becoming a contributor. Let's tackle this together!

I found a similar open issue that might be related to the problem you're experiencing with hidden policy results in custom policies. The issue is titled Formatting issues with policy check results and was last updated on August 09, 2024.

The suggested solution in that issue is to add an extra blank line between the </details> tag and the "Policy Approval Status:" header in the policy_check_results_wrapped.tmpl file. This adjustment seems to correct the formatting issue.

You might want to check if this solution applies to your case and see if it resolves the hidden policy results problem after upgrading to v0.28.0 [1].

To continue talking to Dosu, mention @dosu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant