Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Commit #483

Closed
neilashbysenior opened this issue Feb 19, 2019 · 10 comments
Closed

Code Commit #483

neilashbysenior opened this issue Feb 19, 2019 · 10 comments
Labels
wont-do Unfortunately due to scope or project direction we won't build this in a reasonable amount of time

Comments

@neilashbysenior
Copy link

Hi, I was looking at using Atlantis with AWS CodeCommit and from what I can gather it's not possible to make the webhook work through a trigger to SNS because we can't configure Atlantis to accept the subscription. I haven't seen any Lambda functions knocking about that could achieve the same objective.
I just wanted to confirm that CodeCommit isn't supported as a repository and wondered if this was likely to change in the future?
Thanks,
Neil.

@lkysow
Copy link
Member

lkysow commented Feb 19, 2019

Hi, unfortunately CodeCommit isn't supported and this isn't likely to change in the future.

@neilashbysenior
Copy link
Author

great, thanks for confirming

@lkysow lkysow added the wont-do Unfortunately due to scope or project direction we won't build this in a reasonable amount of time label Feb 19, 2019
@atali
Copy link

atali commented Jun 15, 2019

what is the reason of not supporting codecommit ?

@lkysow
Copy link
Member

lkysow commented Jun 17, 2019

See #32 (comment)

Basically it's a lot of work and makes it harder to maintain the project going forward.

@Govinda-Fichtner
Copy link

Hello Luke,
just a short question regarding AWS CodeCommit. I was wondering if I could just emulate the endpoints that Github (or Gitlab) provides for the webhook integration with Atlantis... and thus create a custom integration with AWS CodeCommit with, for instance a Lambda/ApiGateway-based implementation. Could you point me to some documentation/code that would point me to how such endpoints need to look like?

Thanks. Govinda

@Govinda-Fichtner
Copy link

After a quick look through https://github.com/runatlantis/atlantis/blob/master/server/events/vcs/github_client.go it seems not so easy as to just implement some webhook endpoints. Obviously the github client would need to be able to talk to a backend that can respond to all the Github API calls you make in that file. And the Github hostname is also hardcoded... and I probably missed other aspect as well.

My original idea was if I would be able to quickly create a facade around AWS CodeCommit to make Atlantis use it. Not so sure now if this makes sense...

@lkysow
Copy link
Member

lkysow commented Nov 12, 2019

No I don't think so. There's more than just the client implementation. See what it took for Azure DevOps: #719

@Govinda-Fichtner
Copy link

@lkysow Thanks for your opinion. Do you know of any alternatives that might work with AWS CodeCommit?

@lkysow
Copy link
Member

lkysow commented Nov 12, 2019

Sorry, I do not.

@kclinden
Copy link

kclinden commented Oct 4, 2021

+1 for CodeCommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wont-do Unfortunately due to scope or project direction we won't build this in a reasonable amount of time
Projects
None yet
Development

No branches or pull requests

5 participants