Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic plan server flag #425

Closed
bljordan opened this issue Jan 15, 2019 · 7 comments
Closed

Disable automatic plan server flag #425

bljordan opened this issue Jan 15, 2019 · 7 comments
Labels
wont-do Unfortunately due to scope or project direction we won't build this in a reasonable amount of time

Comments

@bljordan
Copy link

bash-4.4# atlantis version
atlantis 0.4.13

Issue:
I'd like to be able to disable automatic planning as a server flag.
I see this option if using atlantis.yaml files.
https://www.runatlantis.io/docs/atlantis-yaml-reference.html#autoplan

In my opinion, every option that is exposed for individual repos should be able to set as a default server wide. The local atlantis.yaml files could still override the server default if desired.

Why?:
The reason behind this is that we often (not always) use terraform workspaces and the initial plan fails because default workspace errors (intentionally) due to the workspace not being set. Our terraform looks up the workspace and uses that as a map key to cause this intentional error.

@lkysow
Copy link
Member

lkysow commented Jan 17, 2019

Hi Benjamin, this will have to be implemented when #47 is done. It's not sustainable to create global server flags for all possible repo configuration.

@lkysow lkysow added the wont-do Unfortunately due to scope or project direction we won't build this in a reasonable amount of time label Apr 4, 2019
@lkysow
Copy link
Member

lkysow commented Apr 4, 2019

Unfortunately I don't think it makes sense to add this to the Atlantis core. In all other uses cases I'm aware of, there is no need to disable autoplanning at the server level. Since this isn't as popular a use-case I don't think it's worth the added complexity.

@lkysow lkysow closed this as completed Apr 4, 2019
@bljordan
Copy link
Author

bljordan commented Apr 4, 2019

👍 Thanks for the consideration.

@bam0382
Copy link

bam0382 commented May 14, 2019

Hi @lkysow,

We have a configuration with hundreds of workspaces in a repo. We would not want hundreds of plans running when we are just trying to deploy/work from a new workspace. We could really use a flag for this.

@lkysow
Copy link
Member

lkysow commented May 14, 2019

@bam0382 you could list each workspace in the atlantis.yaml and disable autoplan on all of them.

@bam0382
Copy link

bam0382 commented May 15, 2019

Thank you @lkysow. Could we reverse that and white list instead of black list?

@lkysow
Copy link
Member

lkysow commented May 15, 2019

Once you create an atlantis.yaml file, Atlantis will ignore all directories that aren't listed so it kinda is a whitelist already.
For example if I have

dir1/
dir2/

and

version: 3
projects:
- dir: dir1

Then changes in dir2/ will be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wont-do Unfortunately due to scope or project direction we won't build this in a reasonable amount of time
Projects
None yet
Development

No branches or pull requests

3 participants