fix: Investigate why renovate PRs are not running the full CI

[lukemassa]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

A few times (#3748, #3611), changes introduced by renovate had to be reverted because they broke subsequent CI on PRs.

This points to the question of, why was renovate able to merge such changes? It turns out that the renovate config is such that it doesn't run the normal PR CI.

#3743 ran https://github.com/runatlantis/atlantis/actions/runs/6102427320/job/16560883301, which is not the full test suite. The tests did subsequently fail on the merge to master CI https://github.com/runatlantis/atlantis/actions/runs/6102467331/job/16561001966.

Reproduction Steps

Not sure

Logs

N/A

Environment details

N/A

Additional Context

• Conversation in slack: https://atlantis-community.slack.com/archives/C04ES70Q6E8/p1694059957283039
• related pr chore(deps): bump tally to v4 #3498

[nitrocode]

We have required checks to prevent bad commits that break the build. Since these checks (1) run when certain file paths are changed, we also must run the same check name (but simpler and faster) (2) if the paths are not changed.

For some reason the no-op checks (2) are running when instead the real checks (1) should be running.