Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of GH App permission fails pre-hook but runs plan/apply as usual #3608

Open
kirek007 opened this issue Jul 17, 2023 · 2 comments · Fixed by #3611
Open

Lack of GH App permission fails pre-hook but runs plan/apply as usual #3608

kirek007 opened this issue Jul 17, 2023 · 2 comments · Fixed by #3611
Labels
bug Something isn't working Stale

Comments

@kirek007
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

In case Github App is missing permission to update commit status, atlantis is not running pre-hook but it's running workflows as usual. This behavior is not consistent across pre and post hook but also plan/apply phases.

Reproduction Steps

Create an GH App without commit status r/w permissions

Logs

Environment details

Additional Context

@kirek007 kirek007 added the bug Something isn't working label Jul 17, 2023
@kirek007 kirek007 changed the title Lack of GH App permission fails pre-hook but runs plan which is invalid Lack of GH App permission fails pre-hook but runs plan/apply as usual Jul 17, 2023
@X-Guardian
Copy link
Contributor

@GenPage, I think you have accidentally linked to and closed this issue from the vuepress fix PR 3611.

@GenPage GenPage reopened this Aug 4, 2023
@GenPage
Copy link
Member

GenPage commented Aug 4, 2023

whoops 🙃

@dosubot dosubot bot added the Stale label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
3 participants