Allow merging of PR only after a successful apply

[reulan]

Some users who are unfamiliar with Terraform GitHub collaboration via Atlantis, attempt to merge their Terraform code after a successful plan before applying.

I would like to reduce the failure modes with Atlantis for these users by preventing the user from merging after a successful plan and only after a successful apply.

I would like to keep as similar workflow which requires status checks to pass before merging the GitHub Pull Request, but instead of using the general catch-all Atlantis status, I'd like to split it into:

• Atlantis - Plan
• Atlantis - Apply

This way, a successful Plan AND a successful Apply are both required before the user can merge the Pull Request.

[mumoshu]

This sounds like a great idea, and it should be possible by changing atlantis to have a dedicated pull request status for apply.

Currently, atlantis mark the same pull request status successful either plan or apply succeeds. Once they're separated, we use the GitHub's branch protection feature to require status checks to be successful before allowing a merge.

[osterman]

Similarly, it would be nice if we could auto-merge after successful apply, so its closer to a traditional CD pipeline

[dbolack]

This looks related to the needs I'm trying to satisfy. We tried doing this but found that applies would always fail because the mergable test would go from passing to incomplete as part atlantis firing off the reply causing it to no longer be mergable and be an instant atlantis apply fail.

[reulan]

Closed by:
#514

[brandon-fryslie]

Has this functionality been implemented? We would like to prevent any merge on an atlantis PR that hasn't had apply run if possible. I apologize if I'm missing it, but I'm not seeing how PR #514 gives us that functionality. Not every PR in our repo has an associated terraform change, so we can't make atlantis apply a required check for every PR

[benoittgt]

I am also interested in this. I have the same needs as @brandon-fryslie