Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

behave like renovate / avoid comment spam on GH Pull Requests #3367

Open
1 task
jkroepke opened this issue May 2, 2023 · 3 comments
Open
1 task

behave like renovate / avoid comment spam on GH Pull Requests #3367

jkroepke opened this issue May 2, 2023 · 3 comments
Labels
feature New functionality/enhancement Stale

Comments

@jkroepke
Copy link

jkroepke commented May 2, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story
The communication with Atlantis is very spamming. On a Pull Requests It results into a lot of comments which generates a lot of notifications of assigned reviewer. Especially, if the first try wont work, it would result into more unnecessary comments.

Describe the solution you'd like
Like #2818, Atlantis should own only comment if possible. The communication with Atlantis should be done via checkboxes.

Describe the drawbacks of your solution
Larger plans/outputs does not fit into one comments, consider to attach them as file attachment.

Describe alternatives you've considered
Use the check run API to publish the outputs (https://docs.github.com/en/rest/guides/using-the-rest-api-to-interact-with-checks?apiVersion=2022-11-28)

@jkroepke jkroepke added the feature New functionality/enhancement label May 2, 2023
@nitrocode
Copy link
Member

We'd like to implement the checks api which would remove the need for a github comment

@shaul75
Copy link

shaul75 commented May 12, 2023

I think having it post a comment is reasonable if it can support updating the same comment.
IMO the spam problem is due to each push creating and posting new plans. I mean if they were not applied why do I care about them? the current plan is what's important.

@jkroepke
Copy link
Author

@shaul75 The GH Check API is designed for that and can store the plan / apply for each commit separetly. There is no need for an comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement Stale
Projects
None yet
Development

No branches or pull requests

3 participants