Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not post status checks in github if code changes is not relevent #3340

Open
1 task
victor-chan-groundswell opened this issue Apr 19, 2023 · 3 comments
Open
1 task
Labels
feature New functionality/enhancement needs discussion Large change that needs review from community/maintainers Stale

Comments

@victor-chan-groundswell
Copy link

victor-chan-groundswell commented Apr 19, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

We are running a monorepo with our frontend, backend, and TF code all in different directories. I have configured Atlantis.yaml so that actual TF plans and runs only runs on diffs on specific TF directories.... However, on non-relevent PRs, there's still a status check that gets posted on the PR itself that looks like this. We're trying to enforce our engineering team to be mindful of seeing status checks on PRs... Telling them to "ignore this one unless we have TF code" is causing confusion.

image

Describe the solution you'd like

When the PR is not relevent and does not trigger any action atlantis action, allow the option to not post the checks on github

Describe the drawbacks of your solution

I don't see any drawbacks as it gives an option.

Describe alternatives you've considered

whatever it takes to remove engineering team toil....

@victor-chan-groundswell victor-chan-groundswell added the feature New functionality/enhancement label Apr 19, 2023
@GenPage
Copy link
Member

GenPage commented Apr 21, 2023

Thank you for posting about this @victor-chan-groundswell. Unfortunately, this is an intentional design decision.

You can see some historical context here: #1469 (comment)

The reason is that it becomes harder to determine when Atlantis has processed/review a webhook event and debugging those issues is very difficult for the end user. In this case, Atlantis is working as intended by notifying you that no projects were found. This is also helpful for people that use status checks as required.

@nitrocode nitrocode added the needs discussion Large change that needs review from community/maintainers label May 7, 2023
@nitrocode
Copy link
Member

Agreed. I use those checks as required so if they are removed then it would block all my PRs and then I'd be forced to create a github action to make it green which would then need to run whenever atlantis didn't run...

@aalvarezaph
Copy link

@victor-chan-groundswell what does your atlantis.yaml look like? We also have a monorepo and I don't have this behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement needs discussion Large change that needs review from community/maintainers Stale
Projects
None yet
Development

No branches or pull requests

4 participants