PR status summary should remove Note: Objects have changed outside of Terraform

[nitrocode]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

PR status summary should remove Note: Objects have changed outside of Terraform

Reproduction Steps

1. find repo with attributes that have changed (not terraform)
2. terraform 1.3.6, aws 4.50.0
3. atlantis plan

Logs

Environment details

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.vpc.aws_eip.nat[0] has changed
! resource "aws_eip" "nat" {
        # ...
        # (8 unchanged attributes hidden)
    }

Additional Context

• cc: @krrrr38
• Related PR feat: PR check status to show summary e.g. Plan: 1 to add, 0 to change, 1 to destroy #2983

[krrrr38]

Summary doesn't return one line summary 😇

atlantis/server/events/models/models.go

Lines 376 to 386 in ec54d83

	// Summary extracts one line summary of plan changes from TerraformOutput.
	func (p *PlanSuccess) Summary() string {
	note := ""
	if match := reChangesOutside.FindString(p.TerraformOutput); match != "" {
	note = "\n**" + match + "**\n"
	}
	if match := rePlanChanges.FindString(p.TerraformOutput); match != "" {
	return note + match
	}
	return note + reNoChanges.FindString(p.TerraformOutput)
	}