Deprecate old flags

[nitrocode]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

• I'd be willing to implement this feature (contributing guide)

Describe the user story

For 1.0 release, we want to remove the old flags (and respective environment variable) from the code in favor of their respective newer approaches documented below

• https://www.runatlantis.io/docs/server-configuration.html#allow-repo-config
• https://www.runatlantis.io/docs/server-configuration.html#disable-apply
• https://www.runatlantis.io/docs/server-configuration.html#repo-whitelist
• https://www.runatlantis.io/docs/server-configuration.html#require-approval
• https://www.runatlantis.io/docs/server-configuration.html#require-mergeable
• https://www.runatlantis.io/docs/server-configuration.html#silence-whitelist-errors

See issue #2496

Describe the solution you'd like

Remove old flags from the code
Remove old flags from the docs

Describe the drawbacks of your solution

None

Describe alternatives you've considered

None

[DragosDumitrache]

Can I check, is it just the flag that's deprecated? Particularly interested in --require-mergeable. Could I still enable that via the environment variable?

[nitrocode]

It would be both the flag and its environment variable. Instead of require-mergeable, you'd have to use the non-deprecated method after this ticket is completed to keep the same functionality.

[DragosDumitrache]

I see, thanks for getting back to me so quickly. And I assume, much like the server side config file, the repo config is sourced from the current branch of the repo as well, right?

[nitrocode]

@DragosDumitrache the repo config is server side

[DragosDumitrache]

Oh, so, changing it on a branch won't affect the configuration unless a new atlantis is deployed?

[nitrocode]

it's a server side configuration so atlantis will have to be restarted / redeloyed when the change is made