Feature request: per-policyset approver requirements

[pseudomorph]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

• I'd be willing to implement this feature (contributing guide)

Describe the user story

I'd like to be able to define discrete ownership of different policy sets, and require independent review from the corresponding policy owners.

The struct on policy set lead me to think this was already possible (apologies if I've missed something), but it appears that the policy approval workflow only takes the higher-level policysets owner list into consideration when running the policy approval workflow step.

Describe the solution you'd like

With a config like:

policies:
  owners:
    users:
      - some_admin_user
  policy_sets:
    - name: “Policy set 1”
      path: /policy/path/1/
      owners:
        users:
          - policy_set_1_owner
      source: local
    - name: "Policy set 2"
      path: /policy/path/2/
      source: local
      owners:
        users:
          - policy_set_2_owner

A PR which triggers a policies in policyset1 and policyset2 would require review by either an owner of each policy set, or a single review by the admin owner.

Error messages should likely indicate which reviewers are required, or which reviewers remain. The policy_check status check could stay as a singular entity, or be broken out into separate status checks; I'm not sure which is favorable.

Describe the drawbacks of your solution

Would likely require a re-working of project_result model and its use in the policy check, policy approval, and apply workflows.

Describe alternatives you've considered

No other alternatives considered.