Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details link in the PR for logs streaming does not take into account the ATLANTIS_PORT #2132

Closed
pantelis-karamolegkos opened this issue Mar 10, 2022 · 4 comments
Labels
bug Something isn't working provider/github waiting-on-response Waiting for a response from the user

Comments

@pantelis-karamolegkos
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

Despite setting

ATLANTIS_ATLANTIS_URL=https://11.22.33.44
ATLANTIS_PORT=9100

The Details link in the PR does not take in to account the ATLANTIS_PORT and points to (say)

https://11.22.33.44/jobs/MyOrg/MyRepo/34/workspace-name/default

Reproduction Steps

Run atlantis with the following 2 environment variables set

ATLANTIS_ATLANTIS_URL=https://11.22.33.44
ATLANTIS_PORT=9100

Logs

Provide log files from Atlantis server

Mar 10 10:01:42 my-atlantis-server bash[24830]: {"level":"info","ts":"2022-03-10T10:01:42.661Z","caller":"server/server.go:795","msg":"Atlantis started - listening on port 9100","json":{}}

Environment details

If not already included, please provide the following:

  • Atlantis version: 0.18.2
    (using the specific version due to this bug, it turns out it also happens with 0.19.1 which is the latest.

  • If not running the latest Atlantis version have you tried to reproduce this issue on the latest version:

  • Atlantis flags:

Atlantis server-side config file:

- id: "/.*/" # (or <your_repo_id>)
  allow_custom_workflows: true
  workflow: terragrunt
  apply_requirements: [approved, mergeable]
  pre_workflow_hooks:
    - run: terragrunt-atlantis-config generate --ignore-dependency-blocks --output atlantis.yaml --autoplan --filter terragrunt/live/sre
workflows:
  terragrunt:
    plan:
      steps:
      - run: git-crypt unlock
      - run: terragrunt plan -compact-warnings -no-color -out=$PLANFILE
      - run: terragrunt show -no-color -json $PLANFILE > $SHOWFILE
    apply:
      steps:
      - run: terragrunt apply -no-color $PLANFILE

Repo atlantis.yaml file:

# config file

Any other information you can provide about the environment/deployment.

Additional Context

@pantelis-karamolegkos pantelis-karamolegkos added the bug Something isn't working label Mar 10, 2022
@chenrui333
Copy link
Member

Just made a new release 0.19.2, let me know if the issue still happens, thanks!

@pantelis-karamolegkos
Copy link
Contributor Author

Hi @chenrui333 thanks for taking the time to look into this, however the Details link still doesn't append the port after the IP

@jamengual
Copy link
Contributor

is this still happening with v0.19.8?

@jamengual jamengual added the waiting-on-response Waiting for a response from the user label Aug 26, 2022
@github-actions github-actions bot added the Stale label Oct 30, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2022
@jamengual jamengual reopened this Dec 1, 2022
@github-actions github-actions bot removed the Stale label Dec 2, 2022
@github-actions
Copy link

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.'

@github-actions github-actions bot added the Stale label Mar 13, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working provider/github waiting-on-response Waiting for a response from the user
Projects
None yet
Development

No branches or pull requests

3 participants