You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would it be possible to have another apply requirement - something like Approved by CODEOWNERS?
I realize that "mergeable" MOSTLY accomplishes this, because it requires CODEOWNERS approval prior to the PR being mergeable on Github. We also had set "atlantis apply" as a required status prior to making the PR mergeable - to prevent people from accidentally merging planned but not applied changes. Having mergeable and "atlantis apply" as a required status presents a Catch-22 - Atlantis won't let users apply because it's not mergeable yet, and Github won't let it go mergeable because there's no Atlantis apply.
It would be really nice if we could do both - block "atlantis apply" unless a CODEOWNER has approved, but NOT rely on mergeable as the status for this so we can also make "atlantis apply" a required status.
Cheers!
The text was updated successfully, but these errors were encountered:
Yeah we have some custom logic in our fork to ignore atlantis/apply when determining mergeability which basically solves this problem. I can see if we can at least get this upstream since I'm sure this would help a lot of folks.
Would it be possible to have another apply requirement - something like Approved by CODEOWNERS?
I realize that "mergeable" MOSTLY accomplishes this, because it requires CODEOWNERS approval prior to the PR being mergeable on Github. We also had set "atlantis apply" as a required status prior to making the PR mergeable - to prevent people from accidentally merging planned but not applied changes. Having mergeable and "atlantis apply" as a required status presents a Catch-22 - Atlantis won't let users apply because it's not mergeable yet, and Github won't let it go mergeable because there's no Atlantis apply.
It would be really nice if we could do both - block "atlantis apply" unless a CODEOWNER has approved, but NOT rely on mergeable as the status for this so we can also make "atlantis apply" a required status.
Cheers!
The text was updated successfully, but these errors were encountered: