New Policy feature hides plan current plan comment on GitHub

[xarses]

Running from dockerhub runatalntis/atlantis:latest the last few days playing with the new policy feature (#1317) . Yesterday's digest was sha256:0b3d8ba4f5fd37de289bbfb0fb069d4b94ed6befcc8752726430cc5e45f9cefa I can't seem to follow which commit that ties to but it reports as atlantis 0.17.0-beta

In the server config we have hide-prev-plan-comments: true

The most recent atlantis plan results in the plan being marked as hidden (it shows if your on the page when it initially lands, but collapses on refresh)

(Page after loading)

(Expanding plan)

Edit: I also just noticed that all previous Policy workflow posts aren't hidden by and of the newer posts

[nishkrishnan]

I remember this and could have sworn I fixed this for 0.17-beta

[xarses]

I built an image today from

[2021-04-19T21:28:37.697Z] [INFO/_build] Step 1/21 : FROM runatlantis/atlantis:latest
[2021-04-19T21:28:37.797Z] [INFO/_build] latest: Pulling from runatlantis/atlantis
...
[2021-04-19T21:28:43.311Z] [INFO/_build] Digest: sha256:76a99cf7cb7075a3bcefeff71c740e11923edb27983b7238b6c1605b8c60254f

I can confirm the same result. with policy checks enabled and hide-prev-plan-comments: true when you trigger atlantis plan on GitHub

• the CI toggles to in progress as indicated by GitHub's check card
• the plan comment is generated on the current PR (while monitoring the current PR)
• the policy comment is generated on the current PR (while monitoring the current PR)
• the check card on GitHub indicates that all jobs finished

If you refresh the page you can observe:

• all of the Policy check comments are visible
• all of the Plan comments are hidden

[xarses]

Can confirm that #1549 fixes both cases. The the most recent of each command is left visible and all others are hidden