Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-loaded variable files ignore by new filtering in v1.16.0 #1330

Closed
gek0 opened this issue Jan 4, 2021 · 5 comments
Closed

Auto-loaded variable files ignore by new filtering in v1.16.0 #1330

gek0 opened this issue Jan 4, 2021 · 5 comments
Labels
bug Something isn't working waiting-on-response Waiting for a response from the user

Comments

@gek0
Copy link
Contributor

gek0 commented Jan 4, 2021

Regarding #1253

This seems to ignore *.auto.tfvars.json files for the initial auto-plan feature
I'm able to run plan with -d directory flag to run it.
I'm not using --disable-autoplan option!

[INFO] Terraform/aws#1024: Automatically determined that there were 0 projects modified in this pull request: []
We store most of the variables in those *.auto.tfvars.json files, so those are changed in 90% of cases
And since those are per terraform conventions, those extensions should be loaded properly as well

Can confirm it works for *.auto.tfvars but not for *.auto.tfvars.json files

Can I somehow change those extensions via server-side config or add those to source directly as with the above PR?

@jamengual
Copy link
Contributor

Hi @gek0 by looking at the code I do no think this was introduced on that merge request.

have you tested with 1.15 to see if it works?

@gek0
Copy link
Contributor Author

gek0 commented Jan 4, 2021

@jamengual this one 732c90c#diff-702b46964ad1e5a67042badef2fb1bc0452bed69e4db055ab602be5306baf858R151

Tested with v1.15.1 and its working, reverted to that version until fixed

@jamengual
Copy link
Contributor

is this still relevant and tested with v0.19.8?

@jamengual jamengual added bug Something isn't working waiting-on-response Waiting for a response from the user labels Aug 26, 2022
@gek0
Copy link
Contributor Author

gek0 commented Aug 29, 2022

I cannot test it anymore
I did work on this release https://github.com/runatlantis/atlantis/blob/master/CHANGELOG.md#v0161, hopefully someone can run the latest version and check it out

@jamengual
Copy link
Contributor

yes, this works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting-on-response Waiting for a response from the user
Projects
None yet
Development

No branches or pull requests

2 participants