Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Agent Workflow #12

Closed
AryanSakhala opened this issue Oct 23, 2024 · 3 comments
Closed

React Agent Workflow #12

AryanSakhala opened this issue Oct 23, 2024 · 3 comments

Comments

@AryanSakhala
Copy link

AryanSakhala commented Oct 23, 2024

Getting trouble in implementing this with vLLms for all llm functions.

Getting raise ValueError("LLM must be a function calling model!") ValueError: LLM must be a function calling model! specific error.

For all the llm callingfunctions like

llm.get_tool_calls_from_response(
            response, error_on_no_tool_call=False
        )


@logan-markewich
Copy link
Contributor

Correct, vllm does not implement FunctionCallingLLM

Although if I'm reading this right, vllm does support function calling
vllm-project/vllm#7912

But only for certain llms (like llama3.1)

I'd suggest using llama3.2 + the openai server + the OpenAILike class

There's a small example here that you can follow for setup
https://colab.research.google.com/drive/1h-eHhoKUnkJQ2TTsw4HxOd0f1zVd97Ol?usp=sharing

(note, I haven't actually tried this yet with vllm + openai like, but in theory, should work)

The other option is re-implementing the workflow to implement a react loop instead of a function calling loop, but it will be less reliable imo
https://docs.llamaindex.ai/en/stable/examples/workflow/react_agent/

@AryanSakhala
Copy link
Author

Thanks for your help.
React AGet workflow worked but,
React Agent workflow is not yielding the best result

@AryanSakhala
Copy link
Author

Vllm yet is giving bit of a hard time
React agent workflow works but is not the best

Tried with Meta 3.1 70 B Instruct, and variants of Phi, Mistral

I will close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants