feat(github-source): add KeePass2Android #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumboalla
requested changes
Sep 10, 2023
| @@ -83,5 +83,6 @@ val GitHubApps = listOf( | |||
| GitHubApp("com.shadow.blackhole", "Sangwan5688", "BlackHole"), | |||
| GitHubApp("com.zionhuang.music", "z-huang", "InnerTune"), | |||
| GitHubApp("com.nextcloud.client", "nextcloud", "android"), | |||
| GitHubApp("at.bitfire.davdroid", "bitfireAT", "davx5-ose") | |||
| GitHubApp("at.bitfire.davdroid", "bitfireAT", "davx5-ose"), | |||
| GitHubApp("keepass2android.keepass2android", "PhilippC", "keepass2android") | |||
There was a problem hiding this comment.
As it is, this won't work properly. The releases contain 2 apks with different package names and there's no way to know which one is the correct.
There was a problem hiding this comment.
There was a problem hiding this comment.
That won't work because it will always retrieve the first apk. Some extra functionality needs to be added, like a mandatory string match on the filename.
There was a problem hiding this comment.
And on top of this, this app uses absurd version names that are not going to match properly.
There was a problem hiding this comment.
Hmm, so we can do two things regarding this PR:
- Wait until APKUpdater will get a feature to match the string, but that's up to you (in that case, leave the PR open)
- Close this PR because the version names don't make much sense
It's up to you.
|
Closing this one. The last commit added some changes to allow for cases like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers #395 (comment).