Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Failures when asserting array elements in json response #140

Closed
mujx opened this issue Dec 29, 2016 · 5 comments
Closed

Failures when asserting array elements in json response #140

mujx opened this issue Dec 29, 2016 · 5 comments

Comments

@mujx
Copy link

mujx commented Dec 29, 2016

I had some failures with sync::can_sync_a_room_with_a_single_message, here is particular.

The order of the elements in a json array is not guaranteed (I think is alphabetical) so we shouldn't use next to test the existence of the EventIds.

@farodin91
Copy link
Member

The Order of the array is important.
Possible we need to add a order to sql statement. I can lookup the spec later. This array represents the timeline.

@mujx mujx removed the effort/easy label Dec 29, 2016
@mujx
Copy link
Author

mujx commented Dec 29, 2016

I added more events, and it works fine. Still can't figure out what caused the failures.

@mujx
Copy link
Author

mujx commented Dec 29, 2016

I am closing this since I can't reproduce. It was probably an one time thing during development.

@mujx mujx closed this as completed Dec 29, 2016
@mujx
Copy link
Author

mujx commented Dec 30, 2016

I am re-opening because the travis build failed with this error.

@mujx mujx reopened this Dec 30, 2016
@farodin91
Copy link
Member

I think my implementation of sync is incorrect. This need to be test more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants