Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support M1 Mac Architecture for grpc-web #180

Closed
kunal-rp opened this issue Mar 10, 2022 · 5 comments · Fixed by #222 or #227
Closed

Support M1 Mac Architecture for grpc-web #180

kunal-rp opened this issue Mar 10, 2022 · 5 comments · Fixed by #222 or #227
Labels
blocked-external Waiting on external issue/release enhancement New feature or request lang-js JavaScript rules specific resolved-next-release Code to resolve issue is pending release

Comments

@kunal-rp
Copy link

Description

Mono-repo built on intel mac is failing for M1 architecture. The build target is a js grpc web library.

Support for darwin_arm64 will need to be added here :

tool = select({
        "@bazel_tools//src/conditions:darwin_x86_64": "@grpc_web_plugin_darwin//file",
        "@bazel_tools//src/conditions:linux_x86_64": "@grpc_web_plugin_linux//file",
        "@bazel_tools//src/conditions:windows": "@grpc_web_plugin_windows//file",
    }),
@kunal-rp
Copy link
Author

There is no official darwin-arm64 support for grpc-web plugin yet, but mirror link could be created following steps in this thread ? grpc/grpc-web#1159

@aaliddell aaliddell added enhancement New feature or request lang-js JavaScript rules specific blocked-external Waiting on external issue/release labels Mar 15, 2022
@aaliddell
Copy link
Member

Until they have an official ARM M1 build for the plugin, there's not a lot I can reasonably do to support it. Building the plugin myself is beyond the scope of this project and I don't have the necessary hardware anyway.

@kunal-rp
Copy link
Author

It seems like there are github actions for grpc-web repo to build arm artifacts

would this be sufficient ?

@aaliddell
Copy link
Member

Those builds look like they aren't yet attached to a published release. Once v1.4.0 or v1.3.2 is released hopefully they should have the right plugin executables to use here.

@aaliddell aaliddell changed the title Support M1 Mac Architecture Support M1 Mac Architecture for grpc-web Aug 24, 2022
@loeffel-io
Copy link

+1

@aaliddell aaliddell added the resolved-next-release Code to resolve issue is pending release label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-external Waiting on external issue/release enhancement New feature or request lang-js JavaScript rules specific resolved-next-release Code to resolve issue is pending release
Projects
None yet
3 participants