Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port as Chrome/ium extension #2

Open
Jak2k opened this issue Aug 23, 2022 · 2 comments
Open

Port as Chrome/ium extension #2

Jak2k opened this issue Aug 23, 2022 · 2 comments
Labels
blocked issue cannot be solved due to external factors enhancement New feature or request

Comments

@Jak2k
Copy link

Jak2k commented Aug 23, 2022

Background

I can't use it in vivaldi

Proposed solution

An extension for Chromium

Alternatives

Removing the star 🤣

Additional context

@Jak2k Jak2k added the enhancement New feature or request label Aug 23, 2022
@rugk
Copy link
Owner

rugk commented Aug 23, 2022

As elaborated on Twitter I doubt this is easily possible.

I have got some tips to solve the issue with missing cors header that could work in Chrome/ium too, but the DNS api is just not supported in Chromium, so this is unlikely to happen soon.
See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/dns/resolve#browser_compatibility

And that is essentially required to resolve Google IPs.


Even that were solved, there would be the usual remaks about how I would accept such a port:

As always, I refer to rugk/offline-qr-code#59 for details on how to make it.

The TL;DR is: The code base must keep supporting the new WebExtension (promise-based) API of Firefox, but we can include polyfills in the Chrome/ium version. Whether all features really work is not clear, though.

@rugk rugk added the blocked issue cannot be solved due to external factors label Aug 23, 2022
@rugk rugk changed the title A chromIUM extension Port as Chrom/ium extension Aug 23, 2022
@rugk rugk changed the title Port as Chrom/ium extension Port as Chrome/ium extension Aug 23, 2022
@Jak2k
Copy link
Author

Jak2k commented Aug 24, 2022

I readed it already on mastodon.

What about resolving the dns with a request to a dns server (dns over https)?
Or maybee also recognize the google domains?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked issue cannot be solved due to external factors enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants