Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not support one flv video #8891

Open
ivysrono opened this issue Dec 22, 2022 · 3 comments
Open

not support one flv video #8891

ivysrono opened this issue Dec 22, 2022 · 3 comments
Labels
A-avm2 Area: AVM2 (ActionScript 3) A-video bug Something isn't working mixed-avm Mixing AVM1 and AVM2 unimplemented Issues for functionality that hasn't been implemented yet

Comments

@ivysrono
Copy link

Describe the bug

https://zzb.wuxi.gov.cn/doc/2020/12/31/3158429.shtml

Click Run Anyway, get error:

Error dispatching event EventObject(EventObject { type: "timerComplete", class: flash.events::TimerEvent, ptr: 0x2ad388 }) to handler FunctionObject(FunctionObject(GcCell(Gc { ptr: 0x6e18dc }))) : RustError("Property does not exist: Multiname { ns: Single(Package(\"\")), name: Some(\"unescape\"), params: [], flags: (empty) }")

Expected behavior

Play the video.

Affected platform

Browser's extension

Operating system

Win11

Browser

Firefox 108

Additional information

No response

@ivysrono ivysrono added the bug Something isn't working label Dec 22, 2022
@n0samu
Copy link
Member

n0samu commented Dec 22, 2022

Ruffle does not support loading external video files yet. See #3801.

Also, the video file on this page uses the H.264 codec, which is unlikely to be supported by Ruffle anytime soon due to patent/licensing restrictions. Ruffle would need to use the browser's native video playback capabilities, which would be particularly difficult to implement.

@n0samu n0samu added unimplemented Issues for functionality that hasn't been implemented yet A-avm2 Area: AVM2 (ActionScript 3) labels Dec 22, 2022
@Lord-McSweeney
Copy link
Collaborator

Lord-McSweeney commented Mar 11, 2023

This now needs NetConnection.client and mixed AVM support.

@n0samu n0samu added mixed-avm Mixing AVM1 and AVM2 A-video labels Jun 18, 2023
@torokati44
Copy link
Member

At least on desktop, this will be partially fixed by #14654.
For web, I have a WIP (but already functional) branch on top of that PR that delegates H.264 decoding to the browser through the WebCodecs API where supported.

For audio, the AAC-LC audio codec will also have to be wired up (probably/preferably from Symphonia).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) A-video bug Something isn't working mixed-avm Mixing AVM1 and AVM2 unimplemented Issues for functionality that hasn't been implemented yet
Projects
None yet
Development

No branches or pull requests

4 participants