-
-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default value for "Open Links" on the desktop app to "Ask" #17432
Comments
…#17432) Change the defualt value of the "Open Links" setting from "Allow" to "Ask". Having the default value of "Allow" may raise security concerns. More details are in issue ruffle-rs#17432, which this commit solves.
…#17432) Change the default value of the "Open Links" setting from "Allow" to "Ask". Having the default value of "Allow" may raise security concerns. More details are in issue ruffle-rs#17432, which this commit solves.
When I introduced that feature (in #10625), there was a discussion on which value to use as the default |
What could be done is do what I said (change it to "Ask" by default and add a checkbox to be consistent), and then add a new preference to control the default state of that setting to Ruffle user preferences (which get saved to |
Hello there.
Currently, "Open Links" on desktop has "Allow" as the default value.
I want to suggest to change it to "Ask" for two reasons:
Also, "Open Links" option does not follow the pattern of having a checkbox to be able to modify the default value.
Not sure if making "Upgrade HTTP to HTTPS" enabled by default would be a good idea, but since Ruffle runs 100% locally on the Desktop (AFAIK) then it wouldn't be necessary, but would be cool nonetheless.
For the "Open Links" request, I believe changing "allow" to "ask" here would be sufficient.
Thanks in advance for your attention.
The text was updated successfully, but these errors were encountered: