fix: close init after assigning storage settings

[BonapartePC]

Description

Close Init after storage settings are assigned and log errors while uploading proc_errors instead of panic

Notion Ticket

https://www.notion.so/rudderstacks/Allow-Customers-to-use-self-storage-26f45f75e38b4ef6bd872bea6187aa06

Security

• The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[chandumlg]

Are there tests for this?

[chandumlg]

Tests failed. https://github.com/rudderlabs/rudder-server/actions/runs/3427651131/jobs/5710914119

Needs to fix tests to adapt to the new behavior. @BonapartePC

[atzoum]

also got this error while running tests in master

stash_test.go:142:
        	Error Trace:	/Users/aristzoumas/work/rudder-server/processor/stash/stash_test.go:142
        	Error:      	Not equal:
        	            	expected: 3
        	            	actual  : 2
        	Test:       	TestStoreErrorsToObjectStorage

[BonapartePC]

also got this error while running tests in master

stash_test.go:142:
        	Error Trace:	/Users/aristzoumas/work/rudder-server/processor/stash/stash_test.go:142
        	Error:      	Not equal:
        	            	expected: 3
        	            	actual  : 2
        	Test:       	TestStoreErrorsToObjectStorage

Fixed the tests

[codecov]

Codecov Report

Base: 45.43% // Head: 45.43% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1ab0b3b) compared to base (ea8cf4c).
Patch coverage: 67.74% of modified lines in pull request are covered.

Additional details and impacted files

@@              Coverage Diff               @@
##           release/1.3.x    #2678   +/-   ##
==============================================
  Coverage          45.43%   45.43%           
==============================================
  Files                287      287           
  Lines              47777    47803   +26     
==============================================
+ Hits               21707    21721   +14     
- Misses             24691    24703   +12     
  Partials            1379     1379           

Impacted Files	Coverage Δ
processor/stash/stash.go	44.56% <66.66%> (+3.00%)	⬆️
services/fileuploader/fileuploader.go	97.05% <100.00%> (ø)
...rvices/streammanager/kafka/client/testutil/util.go	66.99% <0.00%> (-3.89%)	⬇️
router/router.go	73.77% <0.00%> (-0.09%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.