fix(warehouse): id resolution index issue #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
changed the title
Codecov ReportBase: 45.43% // Head: 45.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/1.3.x #2676 +/- ##
==============================================
Coverage 45.43% 45.43%
==============================================
Files 287 287
Lines 47777 47790 +13
==============================================
+ Hits 21707 21715 +8
- Misses 24691 24698 +7
+ Partials 1379 1377 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…solution tables doesn't contains it.
achettyiitr
requested review from
Jayachand,
abhimanyubabbar,
lvrach and
a team
lvrach
reviewed
Nov 9, 2022
| @@ -396,17 +396,31 @@ func (bq *HandleT) loadTable(tableName string, _, getLoadFileLocFromTableUploads | |||
| primaryJoinClause := strings.Join(primaryKeyList, " AND ") | |||
| bqTable := func(name string) string { return fmt.Sprintf("`%s`.`%s`", bq.namespace, name) } | |||
|
|
|||
| var orderByClause string | |||
| if _, ok := tableColMap["received_at"]; ok { | |||
| orderByClause = "ORDER BY received_at DESC" | |||
There was a problem hiding this comment.
@achettyiitr why it was a problem to always do ORDER BY received_at DESC?
There was a problem hiding this comment.
When enabling ID resolution, we create 2 tables.
- rudder_identity_mappings (merge_property_type, merge_property_value)
- rudder_identity_merge_rules (merge_property_1_type, merge_property_1_value, merge_property_2_type, merge_property_2_value)
There was a problem hiding this comment.
Since these don't contain received_at, it was failing there.
lvrach
approved these changes
Nov 9, 2022
Jayachand
approved these changes
Nov 9, 2022
This was referenced Nov 9, 2022
Merged
atzoum
pushed a commit
that referenced
this pull request
Nov 10, 2022
atzoum
pushed a commit
that referenced
this pull request
Nov 11, 2022
This was referenced Nov 11, 2022
Closed
Closed
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notion Ticket
https://www.notion.so/rudderstacks/ID-Resolution-fix-37b86edc58424110b6562afa4999176f
Security