Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send router transform failures to live events #2637

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Nov 2, 2022

Description

For events which fail at router transform, we are not sending them to live events viewers resulting in customers being unable to view the errors. This PR aims to send those jobs to config backend for live events viewers

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

router/router.go Outdated Show resolved Hide resolved
@cisse21 cisse21 force-pushed the fix.sendLiveEventsRouterTransformFailures branch from 349dc66 to 039ae70 Compare November 2, 2022 08:37
@cisse21 cisse21 force-pushed the fix.sendLiveEventsRouterTransformFailures branch from 32544c7 to 4ebcab8 Compare November 2, 2022 10:05
@cisse21 cisse21 force-pushed the fix.sendLiveEventsRouterTransformFailures branch 4 times, most recently from 2b41f34 to 22b6880 Compare November 3, 2022 06:20
@cisse21 cisse21 force-pushed the fix.sendLiveEventsRouterTransformFailures branch 2 times, most recently from 3b301f8 to 7ecd780 Compare November 3, 2022 06:30
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 43.87% // Head: 43.83% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (d702366) compared to base (cb230b0).
Patch coverage: 18.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2637      +/-   ##
==========================================
- Coverage   43.87%   43.83%   -0.05%     
==========================================
  Files         187      187              
  Lines       40024    40029       +5     
==========================================
- Hits        17560    17546      -14     
- Misses      21368    21385      +17     
- Partials     1096     1098       +2     
Impacted Files Coverage Δ
router/transformer/transformer.go 66.66% <ø> (ø)
router/router.go 74.06% <18.18%> (-0.76%) ⬇️
config/backend-config/namespace_config.go 70.83% <0.00%> (-3.13%) ⬇️
services/rsources/handler.go 69.72% <0.00%> (-1.39%) ⬇️
utils/httputil/server.go 92.30% <0.00%> (+11.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

go.mod Outdated Show resolved Hide resolved
@cisse21 cisse21 force-pushed the fix.sendLiveEventsRouterTransformFailures branch from 7ecd780 to d702366 Compare November 3, 2022 09:28
@cisse21 cisse21 merged commit 6931b17 into master Nov 3, 2022
@cisse21 cisse21 deleted the fix.sendLiveEventsRouterTransformFailures branch November 3, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants