Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modified statsMiddleware to be generic #2626

Merged
merged 6 commits into from
Oct 28, 2022

Conversation

saurav-malani
Copy link
Contributor

Description

Modified statsMiddleware to be more generics. So, that we can import and use it at other places as well, like regulation-manager.

Notion Ticket

https://www.notion.so/rudderstacks/make-gateway-middleware-generic-use-it-in-regulation-manager-749a8f97268e46c3bff11d8474d1ce84

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the code is not formatted (linting step is not passing).

gateway/gateway.go Outdated Show resolved Hide resolved
gateway/gateway.go Outdated Show resolved Hide resolved
chandumlg and others added 2 commits October 28, 2022 09:39
Co-authored-by: Francesco Casula <[email protected]>
Co-authored-by: Francesco Casula <[email protected]>
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 44.08% // Head: 44.05% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (775eb25) compared to base (f13ea33).
Patch coverage: 42.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2626      +/-   ##
==========================================
- Coverage   44.08%   44.05%   -0.04%     
==========================================
  Files         187      187              
  Lines       39255    39255              
==========================================
- Hits        17305    17292      -13     
- Misses      20845    20856      +11     
- Partials     1105     1107       +2     
Impacted Files Coverage Δ
gateway/gateway.go 55.76% <0.00%> (ø)
middleware/middleware.go 94.82% <100.00%> (ø)
enterprise/reporting/setup.go 38.09% <0.00%> (-14.29%) ⬇️
utils/httputil/server.go 80.76% <0.00%> (-11.54%) ⬇️
enterprise/reporting/reporting.go 8.33% <0.00%> (-1.44%) ⬇️
services/rsources/handler.go 69.72% <0.00%> (-1.39%) ⬇️
config/backend-config/namespace_config.go 73.95% <0.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants