-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: modified statsMiddleware to be generic #2626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but the code is not formatted (linting step is not passing).
Co-authored-by: Francesco Casula <[email protected]>
Co-authored-by: Francesco Casula <[email protected]>
Codecov ReportBase: 44.08% // Head: 44.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2626 +/- ##
==========================================
- Coverage 44.08% 44.05% -0.04%
==========================================
Files 187 187
Lines 39255 39255
==========================================
- Hits 17305 17292 -13
- Misses 20845 20856 +11
- Partials 1105 1107 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
Modified
statsMiddleware
to be more generics. So, that we can import and use it at other places as well, like regulation-manager.Notion Ticket
https://www.notion.so/rudderstacks/make-gateway-middleware-generic-use-it-in-regulation-manager-749a8f97268e46c3bff11d8474d1ce84
Security