Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix defect with router destinations map access event order #2589

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Oct 19, 2022

Description

Updating job status in the barrier. Regression introduced by #2582

Notion Ticket

fix: router destination map access

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth changed the title fix.routerDestinationsMapAccessEventOrder fix.router Destinations Map Access Event Order Oct 19, 2022
@Sidddddarth Sidddddarth changed the title fix.router Destinations Map Access Event Order fix: router Destinations Map Access Event Order Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 44.00% // Head: 43.98% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a416ddb) compared to base (09dba21).
Patch coverage: 85.71% of modified lines in pull request are covered.

❗ Current head a416ddb differs from pull request most recent head a0595b7. Consider uploading reports for the commit a0595b7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
- Coverage   44.00%   43.98%   -0.02%     
==========================================
  Files         187      187              
  Lines       39086    39098      +12     
==========================================
- Hits        17198    17196       -2     
- Misses      20807    20820      +13     
- Partials     1081     1082       +1     
Impacted Files Coverage Δ
router/router.go 67.71% <85.71%> (+0.11%) ⬆️
warehouse/schema.go 47.82% <0.00%> (-1.16%) ⬇️
processor/processor.go 71.23% <0.00%> (-0.83%) ⬇️
enterprise/reporting/reporting.go 9.77% <0.00%> (+1.43%) ⬆️
enterprise/reporting/setup.go 52.38% <0.00%> (+14.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sidddddarth Sidddddarth force-pushed the fix.routerDestinationsMapAccessEventOrder branch 2 times, most recently from a416ddb to 3e45fd1 Compare October 19, 2022 10:52
@Sidddddarth Sidddddarth force-pushed the fix.routerDestinationsMapAccessEventOrder branch from 3e45fd1 to a0595b7 Compare October 19, 2022 16:28
@atzoum atzoum changed the title fix: router Destinations Map Access Event Order chore: fix defect with router destinations map access event order Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants