feat: add support for role based auth flag #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
force-pushed
the
feat.add-support-for-role-based-auth-flag
branch
from
c2a94c0
to
34411ab
Compare
Currently we are not able to delete already stored secrets from Config BE DB so we are adding support role based auth flag so that users can easily switch between AWS Access Keys and Roles.
koladilip
force-pushed
the
feat.add-support-for-role-based-auth-flag
branch
from
34411ab
to
91f425d
Compare
Codecov ReportBase: 45.36% // Head: 45.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
- Coverage 45.36% 45.35% -0.01%
==========================================
Files 175 175
Lines 36377 36387 +10
==========================================
+ Hits 16502 16503 +1
- Misses 18799 18808 +9
Partials 1076 1076
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Tested on dev cluster and changes are working as expected. |
saikumarrs
approved these changes
Oct 6, 2022
cisse21
approved these changes
Oct 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we are not able to delete already stored secrets from Config BE DB so we are adding for support roleBasedAuth flag so that users can easily switch between AWS Access Keys and Roles. This enables to revert back to Access keys if users are getting any troubles after migrating to the AWS roles.
Notion Ticket
https://www.notion.so/AWS-FTR-Support-RoleBasedAuth-Flag-5cfd191922ae4f6eb4a8fc75dca40ac3
Security