fix: remove custom credentials chain to use default #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikumarrs
approved these changes
Sep 27, 2022
Codecov ReportBase: 40.55% // Head: 40.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2485 +/- ##
==========================================
+ Coverage 40.55% 40.60% +0.04%
==========================================
Files 174 174
Lines 36259 36252 -7
==========================================
+ Hits 14706 14720 +14
+ Misses 20635 20615 -20
+ Partials 918 917 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
psrikanth88
approved these changes
Sep 27, 2022
utils/awsutils/session.go
Outdated
| @@ -46,6 +44,9 @@ func createDefaultSession(config *SessionConfig) (*session.Session, error) { | |||
| } | |||
|
|
|||
| func createCredentailsForRole(config *SessionConfig) (*credentials.Credentials, error) { | |||
| if config.ExternalID == "" { | |||
| return nil, errors.New("externalID is required fo IAM role") | |||
…rudderlabs/rudder-server into fix.aws-session-utils-use-default-chain
cisse21
approved these changes
Sep 27, 2022
Closed
Merged
github-actions
bot
deleted the
fix.aws-session-utils-use-default-chain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OSS user reported that custom credentials chain is causing issues so removing to use default chain provided by SDK.
I have mistakenly configured AWS creds chain thinking about requirements from Kubernetes stand point and missed other types deployment like ECS so it is causing failures in ECS tasks when users want to task role instead of access keys from destination config. When no chain is mentioned default chain is taking care of this use case without any issues.
Notion Ticket
https://www.notion.so/rudderstacks/AWS-FTR-fix-OSS-issues-d64b93d9ed1d4c00a8d7e5573f7992c3
Security