Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: applying 1.1.1 hotfixes to main branch #2449

Merged
merged 2 commits into from
Sep 16, 2022
Merged

chore: applying 1.1.1 hotfixes to main branch #2449

merged 2 commits into from
Sep 16, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Sep 15, 2022

Description

Applying 1.1.x hotfixes to main branch

@atzoum atzoum marked this pull request as ready for review September 15, 2022 12:00
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #2449 (bf719d8) into master (5085d1c) will increase coverage by 1.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2449      +/-   ##
==========================================
+ Coverage   36.15%   37.33%   +1.18%     
==========================================
  Files         200      200              
  Lines       39647    40477     +830     
==========================================
+ Hits        14335    15114     +779     
- Misses      24407    24447      +40     
- Partials      905      916      +11     
Impacted Files Coverage Δ
...connection-tester/destination_connection_tester.go 15.38% <100.00%> (+1.09%) ⬆️
enterprise/reporting/setup.go 38.09% <0.00%> (-14.29%) ⬇️
enterprise/reporting/reporting.go 8.38% <0.00%> (-1.45%) ⬇️
processor/processor.go 71.59% <0.00%> (-0.88%) ⬇️
router/internal/eventorder/eventorder.go 97.15% <0.00%> (+0.09%) ⬆️
jobsdb/jobsdb.go 71.33% <0.00%> (+2.82%) ⬆️
router/router.go 71.45% <0.00%> (+3.96%) ⬆️
gateway/gateway.go 57.36% <0.00%> (+5.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atzoum atzoum changed the title fix: close http response body only if there is no error (#2447) chore: applying 1.1.1 hotfixes to main branch Sep 15, 2022
@atzoum atzoum merged commit ac9afbd into master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants