Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make limiter's end function idempotent #71

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented Jun 30, 2023

Description

Limiter's end function can be now called multiple times

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (5f83762) 78.00% compared to head (6cf22d0) 78.10%.

❗ Current head 6cf22d0 differs from pull request most recent head 47d3f7b. Consider uploading reports for the commit 47d3f7b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   78.00%   78.10%   +0.10%     
==========================================
  Files          67       67              
  Lines        4815     4819       +4     
==========================================
+ Hits         3756     3764       +8     
+ Misses        861      856       -5     
- Partials      198      199       +1     
Impacted Files Coverage Δ
sync/limiter.go 92.10% <100.00%> (+0.21%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum merged commit cd5826d into main Jul 3, 2023
@atzoum atzoum deleted the chore.endOnce branch July 3, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants