feat: introduce gittest #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debanjan97
reviewed
Sep 5, 2024
| } | ||
|
|
||
| func getLocalIP(t testing.TB) string { | ||
| conn, err := net.Dial("udp", "8.8.8.8:80") |
There was a problem hiding this comment.
this seems like a very common way: https://github.com/search?q=%22net.Dial%28%5C%22udp%5C%22%2C+%5C%228.8.8.8%3A80%5C%22%29%22&type=code
There was a problem hiding this comment.
stackoverflow, that's why!
https://stackoverflow.com/questions/23558425/how-do-i-get-the-local-ip-address-in-go/37382208#37382208
maheshkutty
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gittest: provides a test helper for creating a git server that serves a git repository.httptest: provides similar functionality to thenet/http/httptestpackage, but with some additional features: (1) It allows you to listen to all interfaces, not just localhost and (2) for TLS servers, it allows you to specify the host name to use in the certificate.Security