-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add encryption support #627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir20
force-pushed
the
mihir/pipe-1491
branch
from
September 5, 2024 13:39
7cf9de1
to
9d6f4b6
Compare
mihir20
force-pushed
the
mihir/pipe-1491
branch
from
September 9, 2024 10:34
e5be841
to
6d9bb4a
Compare
mihir20
force-pushed
the
mihir/pipe-1491
branch
from
September 9, 2024 10:45
3775df2
to
8626e60
Compare
fracasula
approved these changes
Sep 9, 2024
achettyiitr
approved these changes
Sep 10, 2024
lvrach
reviewed
Sep 10, 2024
lvrach
approved these changes
Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for encryption and decryption. We are using AES a symmetric key algorithm. AES supports different authentication mechanism for verification of cipher text. We have only implemented GCM(Galois Counter Mode) authentication modes for now. We can add support for more in the future.
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1491/%5Bha-ingestion%5D-go-kit-encryption-changes
Security