Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add encryption support #627

Merged
merged 12 commits into from
Sep 11, 2024
Merged

feat: add encryption support #627

merged 12 commits into from
Sep 11, 2024

Conversation

mihir20
Copy link
Contributor

@mihir20 mihir20 commented Sep 4, 2024

Description

Add support for encryption and decryption. We are using AES a symmetric key algorithm. AES supports different authentication mechanism for verification of cipher text. We have only implemented GCM(Galois Counter Mode) authentication modes for now. We can add support for more in the future.

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-1491/%5Bha-ingestion%5D-go-kit-encryption-changes

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@mihir20 mihir20 marked this pull request as ready for review September 4, 2024 14:24
@mihir20 mihir20 marked this pull request as draft September 5, 2024 07:21
@mihir20 mihir20 marked this pull request as ready for review September 6, 2024 11:39
encrypt/aes_cfb.go Outdated Show resolved Hide resolved
@mihir20 mihir20 requested a review from lvrach September 11, 2024 13:34
@mihir20 mihir20 merged commit e26c3e4 into main Sep 11, 2024
14 checks passed
@mihir20 mihir20 deleted the mihir/pipe-1491 branch September 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants