-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kafka client and containers #287
Merged
fracasula
merged 38 commits into
main
from
feature/pipe-700-kafka-client-and-destination-for-integration-testing
Jan 30, 2024
Merged
feat: kafka client and containers #287
fracasula
merged 38 commits into
main
from
feature/pipe-700-kafka-client-and-destination-for-integration-testing
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracasula
force-pushed
the
feature/pipe-700-kafka-client-and-destination-for-integration-testing
branch
from
January 17, 2024 16:50
33c75a9
to
ac335ce
Compare
fracasula
changed the title
Feature/pipe 700 kafka client and destination for integration testing
feat: kafka client and containers
Jan 17, 2024
fracasula
force-pushed
the
feature/pipe-700-kafka-client-and-destination-for-integration-testing
branch
from
January 22, 2024 12:10
1c10c62
to
4a26115
Compare
fracasula
force-pushed
the
feature/pipe-700-kafka-client-and-destination-for-integration-testing
branch
from
January 22, 2024 12:20
4a26115
to
3e5476c
Compare
fracasula
force-pushed
the
feature/pipe-700-kafka-client-and-destination-for-integration-testing
branch
from
January 22, 2024 16:24
44b7307
to
a880476
Compare
fracasula
requested review from
lvrach,
cisse21,
mihir20,
BonapartePC,
achettyiitr and
Sidddddarth
January 23, 2024 09:32
lvrach
approved these changes
Jan 30, 2024
) | ||
|
||
type MinioResource struct { | ||
type Resource struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next rudder-go-kit will be introducing breaking changes. Not sure if people other than rudder-server are using these packages, but we should communicate the changes and provide upgrade instructions.
achettyiitr
approved these changes
Jan 30, 2024
…n-for-integration-testing
fracasula
deleted the
feature/pipe-700-kafka-client-and-destination-for-integration-testing
branch
January 30, 2024 11:59
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving Kafka client and container test helpers in the go-kit to share across new ingestion layer services and PoC.
Linear Ticket
< Linear_Link >
Security