Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kafka client and containers #287

Conversation

fracasula
Copy link
Collaborator

Description

Moving Kafka client and container test helpers in the go-kit to share across new ingestion layer services and PoC.

Linear Ticket

< Linear_Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@fracasula fracasula force-pushed the feature/pipe-700-kafka-client-and-destination-for-integration-testing branch from 33c75a9 to ac335ce Compare January 17, 2024 16:50
@fracasula fracasula changed the title Feature/pipe 700 kafka client and destination for integration testing feat: kafka client and containers Jan 17, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 184 lines in your changes are missing coverage. Please review.

Comparison is base (7385e0d) 79.74% compared to head (667f31e) 79.70%.

Files Patch % Lines
testhelper/docker/resource/kafka/kafka.go 78.43% 38 Missing and 17 partials ⚠️
kafkaclient/testutil/util.go 69.09% 27 Missing and 7 partials ⚠️
kafkaclient/producer.go 78.15% 21 Missing and 5 partials ⚠️
testhelper/docker/resource/sshserver/sshserver.go 75.23% 18 Missing and 8 partials ⚠️
kafkaclient/client.go 83.33% 10 Missing and 4 partials ⚠️
kafkaclient/consumer.go 81.48% 9 Missing and 1 partial ⚠️
tcpproxy/tcpproxy.go 83.63% 7 Missing and 2 partials ⚠️
kafkaclient/config.go 94.52% 3 Missing and 1 partial ⚠️
testhelper/docker/resource/redis/redis.go 60.00% 3 Missing and 1 partial ⚠️
testhelper/docker/resource/types.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   79.74%   79.70%   -0.05%     
==========================================
  Files          75       85      +10     
  Lines        5634     6495     +861     
==========================================
+ Hits         4493     5177     +684     
- Misses        928     1060     +132     
- Partials      213      258      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fracasula fracasula force-pushed the feature/pipe-700-kafka-client-and-destination-for-integration-testing branch from 1c10c62 to 4a26115 Compare January 22, 2024 12:10
@fracasula fracasula force-pushed the feature/pipe-700-kafka-client-and-destination-for-integration-testing branch from 4a26115 to 3e5476c Compare January 22, 2024 12:20
@fracasula fracasula force-pushed the feature/pipe-700-kafka-client-and-destination-for-integration-testing branch from 44b7307 to a880476 Compare January 22, 2024 16:24
@fracasula fracasula marked this pull request as ready for review January 23, 2024 09:32
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
)

type MinioResource struct {
type Resource struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next rudder-go-kit will be introducing breaking changes. Not sure if people other than rudder-server are using these packages, but we should communicate the changes and provide upgrade instructions.

@fracasula fracasula merged commit 00cba9d into main Jan 30, 2024
13 checks passed
@fracasula fracasula deleted the feature/pipe-700-kafka-client-and-destination-for-integration-testing branch January 30, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants