Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "deletion_time" does not work with sentinel_value #530

Closed
sherif-nedap opened this issue Mar 17, 2022 · 4 comments
Closed

New "deletion_time" does not work with sentinel_value #530

sherif-nedap opened this issue Mar 17, 2022 · 4 comments

Comments

@sherif-nedap
Copy link
Contributor

#481

if you use a sentinel_value that uses a boolean value instead of timestamp
@mathieujobin
Copy link
Collaborator

would you be able to write a test that reproduce this issue please?

@sherif-nedap
Copy link
Contributor Author

@mathieujobin i have created a test for it and discovered where the issue is..

#531

@sherif-nedap
Copy link
Contributor Author

#531 (comment)

@mathieujobin mathieujobin mentioned this issue Mar 23, 2022
Merged
@mathieujobin
Copy link
Collaborator

thanks for the report and the test

fix pushed in v2.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathieujobin @sherif-nedap