Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install generator needs better tests #89

Closed
radar opened this issue Dec 1, 2011 · 2 comments
Closed

Install generator needs better tests #89

radar opened this issue Dec 1, 2011 · 2 comments

Comments

@radar
Copy link
Collaborator

radar commented Dec 1, 2011

We just ran into an issue where the fix for #88 caused the install generator to break for new applications. It was requiring the user_class configuration option to set and was giving a non-trivial error message to users.

I think that we should have a test for the install generator which is more of an "integration" test than the current "unit" test that lives in spec/generators. This integration test should use the wonderful Aruba to create a brand new Rails application and walk through the install steps for Forem, running checks on the output of the content of the installer.

Without this, there's a chance that any change to Forem could again break the install generator, and when that happens anybody who's trying out Forem for the first time will see this and think bad things about Forem. The install generator (and the installation process) should amaze people at what it did for them and how easy it was.

Let's not break this again, ever.

Massive thanks to Aston J for pointing this out.

@radar
Copy link
Collaborator Author

radar commented Dec 22, 2011

There's now also #102 which is caused by problems with the way that this is being tested. Perhaps fakefs should be looked into as a possible alternative to this.

@radar
Copy link
Collaborator Author

radar commented Feb 20, 2012

This is fixed by #149.

@radar radar closed this as completed Feb 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant