Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel controls overflow in home page #19

Closed
arielj opened this issue Aug 24, 2021 · 6 comments · Fixed by #53
Closed

Carousel controls overflow in home page #19

arielj opened this issue Aug 24, 2021 · 6 comments · Fixed by #53
Assignees
Labels
Help Wanted 🆘 Extra attention is needed Type: UX/UI 💄 Frontend changes

Comments

@arielj
Copy link
Contributor

arielj commented Aug 24, 2021

The controls of the carousel at the bottom of the page are placed outside the container, adding extra width to the document and adding that extra scroll to the right side.

rubyforgood org_(iPhone X) (1)

Some options to fix this:

  1. hide the controls for the resolution when they start to not fit into the width
  2. or, resize the container of the carousel so the controls are still inside the viewport

I think option 1 is simpler since on those devices the user can move the carousel swiping with the thouch

@meg-gutshall meg-gutshall added Help Wanted 🆘 Extra attention is needed Type: UX/UI 💄 Frontend changes labels Oct 27, 2021
@grazirs
Copy link
Contributor

grazirs commented Jul 18, 2022

Hi, @meg-gutshall! Can I get this issue?

@meg-gutshall meg-gutshall added the Status: Blocked 🚫 Something else is blocking this label Jul 20, 2022
@meg-gutshall
Copy link
Member

Hi Graziele! Thank you for jumping in and volunteering!

I will assign you this issue, but I'm going to mark it as blocked for now. Tonight I will go on and make sure everything is up-to-date on here (I've been focusing on Human Essentials lately, so I have to check up on the status of this) and then unblock it when it's ready for contribution!

Does that sound good to you? Please let me know if you have any questions!

@meg-gutshall
Copy link
Member

Hey @grazirs! Thank you for your contribution! It looks good, but what I really want to do in the long run is rip out OwlCarousel and Slick and replace them with Flickity. Would you be up to taking on that task? I know it's a bit large, but I'm being pulled in a lot of different directions and haven't been able to make as much progress on this site as I would have liked.

If not, that's fine and I can merge in your PR as is. Just let me know!

@grazirs
Copy link
Contributor

grazirs commented Aug 1, 2022

Hey @meg-gutshall, sure! I can work on it. Is the goal to reproduce the same design and behaviors with Flickity?

@meg-gutshall
Copy link
Member

That's correct! Right now, they're all shoved into assets/js/main.js. It would be nice to have them cleaned up and separated out a bit. I'll write up a new issue real quick and assign it to you. Thanks a ton!

@meg-gutshall meg-gutshall removed the Status: Blocked 🚫 Something else is blocking this label Aug 2, 2022
@meg-gutshall
Copy link
Member

Hi @grazirs, I created the new issue #54 this afternoon, but I think you have to comment on it before I can assign it to you since you're not listed as a member in the Ruby for Good GitHub organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted 🆘 Extra attention is needed Type: UX/UI 💄 Frontend changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants