Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Flaky Test #5120

Closed
schoork opened this issue Aug 15, 2023 · 6 comments
Closed

Bug: Flaky Test #5120

schoork opened this issue Aug 15, 2023 · 6 comments
Labels
Help Wanted This is a special label that enables github to showcase issues that want help Type: Bug

Comments

@schoork
Copy link
Collaborator

schoork commented Aug 15, 2023

Flaky tests are defined as tests that return both passes and failures despite no changes to the code or the test itself
Fix the test so it runs consistently.

CI Workflow

rspec

Sample Error Output:

1) view all volunteers supervisor user can persist 'show/hide' column preference settings
     Failure/Error: visit volunteers_path

     Selenium::WebDriver::Error::UnexpectedAlertOpenError:
       unexpected alert open: {Alert text : You need to sign in before continuing.}
         (Session info: headless chrome=115.0.5790.170)

rspec ./spec/system/volunteers/index_spec.rb:251 # view all volunteers supervisor user can persist 'show/hide' column preference settings

screenshot_2023-08-15-18-18-54 809

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

@schoork schoork added Type: Bug Help Wanted This is a special label that enables github to showcase issues that want help labels Aug 15, 2023
@seanmarcia seanmarcia assigned seanmarcia and unassigned seanmarcia Aug 16, 2023
@github-actions github-actions bot removed the Help Wanted This is a special label that enables github to showcase issues that want help label Aug 16, 2023
@seanmarcia seanmarcia removed their assignment Aug 16, 2023
@seanmarcia seanmarcia added the Help Wanted This is a special label that enables github to showcase issues that want help label Aug 16, 2023
@MarchandMD
Copy link
Contributor

Hey! I'm happy to tackle this!

I found this in the wild and have had some success getting past those flaky tests.

Please assign me and @Yuji3000 Thanks!

@MarchandMD
Copy link
Contributor

Hey @schoork , can you provide a little more detail here; Were you experiencing issues in the CI workflow?

What are the steps I need to take to duplicate the errors you're seeing?

@schoork
Copy link
Collaborator Author

schoork commented Oct 16, 2023

Hey @MarchandMD. It failed during a run of the Docker CI workflow, when it shouldn't have. Looking at the ticket now, I can't see the line in the test if failed on (Whoops!). If you can see anything in the test code that looks like it might be a little rickety, fix that. Otherwise, I'd say we close this with too little information.

Thanks for looking at it!

@MarchandMD
Copy link
Contributor

@schoork I did research the Selenium webdriver issue, but I think that falls outside the scope of your intended ticket.

I'm fine with this being closed without more details. Thanks for the response.

@Yuji3000
Copy link

@schoork Sounds good, Thanks for letting us know.

@schoork
Copy link
Collaborator Author

schoork commented Oct 18, 2023

Not enough information to reproduce.

@schoork schoork closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2023
@github-project-automation github-project-automation bot moved this from Todo to Merged to QA in CASA Volunteer Portal Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted This is a special label that enables github to showcase issues that want help Type: Bug
Projects
Archived in project
Development

No branches or pull requests

4 participants