Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially refactor how file uploads are handled. #269

Open
benreyn opened this issue Sep 5, 2020 · 2 comments
Open

Potentially refactor how file uploads are handled. #269

benreyn opened this issue Sep 5, 2020 · 2 comments
Labels
Needs: Discussion

Comments

@benreyn
Copy link
Member

benreyn commented Sep 5, 2020

Currently we read file contents and save them on the contents column of the temporary_files table. This could be unsafe. Im not aware of any restrictions that we have in regards to file uploads, but it would probably be better to upload the file to S3 or something?
@mdworken
Copy link
Member

mdworken commented Sep 6, 2020

@benreyn I think this would be a good idea, and may have been part of the original plan to do this eventually.

@benreyn
Copy link
Member Author

benreyn commented Sep 6, 2020

Keep in mind, that #276 relies pretty heavily on the existing implementation. When and if we decide to tackle this, that code will need to be refactored.

@CraigJZ CraigJZ mentioned this issue Sep 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benreyn @mdworken