Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow measurements on the "allow list" to be uploaded #241

Open
4 tasks
mdworken opened this issue Aug 20, 2020 · 3 comments
Open
4 tasks

Only allow measurements on the "allow list" to be uploaded #241

mdworken opened this issue Aug 20, 2020 · 3 comments

Comments

@mdworken
Copy link
Member

mdworken commented Aug 20, 2020

Users will enter custom measurements through the measurements csv. To avoid issues with misspelled measurement values or inconsistent namings/capitalization, we would like to make an Organization-wide "allow list" (we're intentionally avoiding the equivalent term "whitelist") of acceptable measurements.

For this issue, we want to prevent the CSV upload from being accepted by adding a validation to the Measurement model that requires the "name" is on the organizations allowlist.

Acceptance Criterion
Case 1 the organization has configured one or more allowlist names:

  • A measurement that has a name that is NOT on the allowlist will be invalid
  • An appropriate error is raised from the upload screen* (see below)
  • Screenshot of the error

Case 2 the organization has not configured their allowlist

  • The validation of measurement name is NOT active for that organization

NOTE
This ticket is dependent on the work that will be done in #207 and is blocked until that work is completed.

  • this behavior should come for free from the model's validation error
@benreyn benreyn changed the title Only allow measurements on the "accept list" to be uploaded Only allow measurements on the "allow list" to be uploaded Aug 21, 2020
@benreyn
Copy link
Member

benreyn commented Sep 17, 2020

Setting of the allowlist items will be an in app functionality (not csv upload)

@NickSchimek
Copy link
Member

Is this still blocked? Can I do this one?

@vurtn
Copy link
Contributor

vurtn commented Oct 17, 2021

Can i work on it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants