Rewrite IPAddr.new.include? with pure Ruby bit operation
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
reviewed
Jul 28, 2024
There was a problem hiding this comment.
I'm not particularly in favor of implementing another IP address parser to maintain.
Leaving aside the maintenance cost, there would be concerns about regression and incompatibility. I think the new implementation has to be tested with all IP address patterns that IPAddr can handle in the test suite, and it also has to reject invalid addresses that IPAddr rejects.
Maybe this is not a strict requirement because it silently ignores any malformed address and returns false. |
|
@knu Thanks, I also agree your comment. I added only simple IPv4 and IPv6 pattern. I keep open this until another idea will be available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to reduce across stdlib dependencies. I remove
IPAddrand rewrite that to rough bit operation.