Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide cache-hit output #305

Closed
dhvcc opened this issue Apr 5, 2022 · 3 comments
Closed

Provide cache-hit output #305

dhvcc opened this issue Apr 5, 2022 · 3 comments

Comments

@dhvcc
Copy link

dhvcc commented Apr 5, 2022

I'd like to propose adding cache-hit output, since this action utilizes actions/cache. This proposal was originally made in actions/setup-python#371, so full justification can be found here (this is for python, but I think it doesn't matter that much?)

@eregon
Copy link
Member

eregon commented Apr 5, 2022

Do you have a concrete example how this output would be useful?

From that linked issue:

This would be helpful if, for example, we need add stuff to PATH if this cache was hit.

I don't see how that would apply here. No matter cache hit or not the PATH would be the same.

@dhvcc
Copy link
Author

dhvcc commented Apr 5, 2022

Sure, I'll try to find more ruby-related reasons and get back at you. Thanks for the response!

@dhvcc
Copy link
Author

dhvcc commented Apr 20, 2022

It seems like all use cases for this feature are really covered by this action, closing this

@dhvcc dhvcc closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants