Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should set self_type to self #2029

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Should set self_type to self #2029

merged 1 commit into from
Sep 27, 2024

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Sep 27, 2024

Fixed self_type in block for class_eval and module_eval.
See also soutaro/steep#1232

soutaro
soutaro approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@soutaro soutaro added this to the RBS 3.6 milestone Sep 27, 2024
@soutaro soutaro added this pull request to the merge queue Sep 27, 2024
Merged via the queue into ruby:master with commit abd609b Sep 27, 2024
19 checks passed
@ksss ksss deleted the eval-block-self-type branch September 27, 2024 08:09
@ksss ksss mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro